Change in openvpn[master]: packet_id: Fix build with --disable-debug
A message that is not in the archive (sent off-list or not yet received): gerrit.1751292607000.I3bed9c7aafee8e62ddae14c0d3e21cf4c146a37c@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1071?usp=email
to review the following change.
Change subject: packet_id: Fix build with --disable-debug
......................................................................
packet_id: Fix build with --disable-debug
Broken since commit bc62a9a02cb7365a678bcd3f2faf537a420cc5a0
"Add methods to read/write packet ids for epoch data"
---
M src/openvpn/packet_id.c
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/71/1071/1
src/openvpn/packet_id.c +2 -3
@@ -673,6 +673,8 @@ gc_free(&gc); } +#endif /* ifdef ENABLE_DEBUG */ +uint16_t packet_id_read_epoch (struct packet_id_net *pin,struct buffer *buf) {
@@ -711,6 +713,3 @@return buf_write (buf, &net_id,sizeof (net_id)); } - - -#endif /* ifdef ENABLE_DEBUG */
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1071?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3bed9c7aafee8e62ddae14c0d3e21cf4c146a37c
Gerrit-Change-Number: 1071
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newchange
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1071?usp=email )
Change subject: packet_id: Fix build with --disable-debug
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1071?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3bed9c7aafee8e62ddae14c0d3e21cf4c146a37c
Gerrit-Change-Number: 1071
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Mon, 30 Jun 2025 16:41:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
PATCH 1/1 packet_id: Fix build with --disable-debug
In reply to a message not in the archiveFrom: Frank Lichtenheld <[email protected]...>
Broken since commit bc62a9a02cb7365a678bcd3f2faf537a420cc5a0
"Add methods to read/write packet ids for epoch data"
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1071
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>
src/openvpn/packet_id.c +2 -3
@@ -673,6 +673,8 @@ gc_free(&gc); } +#endif /* ifdef ENABLE_DEBUG */ +uint16_t packet_id_read_epoch (struct packet_id_net *pin,struct buffer *buf) {
@@ -711,6 +713,3 @@return buf_write (buf, &net_id,sizeof (net_id)); } - - -#endif /* ifdef ENABLE_DEBUG */
[Openvpn-devel] [PATCH applied] Re: packet_id: Fix build with --disable-debug
"Obviously correct" ;-) - not tested beyond what the buildbots do anyway.
Your patch has been applied to the master branch.
commit 16c1da39e93578766acd6ba085f4960190fd6220
Author: Frank Lichtenheld Date: Mon Jun 30 18:42:01 2025 +0200
packet_id: Fix build with --disable-debug
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32013.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1071?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: packet_id: Fix build with --disable-debug
......................................................................
packet_id: Fix build with --disable-debug
Broken since commit bc62a9a02cb7365a678bcd3f2faf537a420cc5a0
"Add methods to read/write packet ids for epoch data"
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32013.html
---
M src/openvpn/packet_id.c
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/71/1071/2
src/openvpn/packet_id.c +2 -3
@@ -673,6 +673,8 @@ gc_free(&gc); } +#endif /* ifdef ENABLE_DEBUG */ +uint16_t packet_id_read_epoch (struct packet_id_net *pin,struct buffer *buf) {
@@ -711,6 +713,3 @@return buf_write (buf, &net_id,sizeof (net_id)); } - - -#endif /* ifdef ENABLE_DEBUG */
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1071?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3bed9c7aafee8e62ddae14c0d3e21cf4c146a37c
Gerrit-Change-Number: 1071
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1071?usp=email )
Change subject: packet_id: Fix build with --disable-debug
......................................................................
packet_id: Fix build with --disable-debug
Broken since commit bc62a9a02cb7365a678bcd3f2faf537a420cc5a0
"Add methods to read/write packet ids for epoch data"
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32013.html
---
M src/openvpn/packet_id.c
1 file changed, 2 insertions(+), 3 deletions(-)
src/openvpn/packet_id.c +2 -3
@@ -673,6 +673,8 @@ gc_free(&gc); } +#endif /* ifdef ENABLE_DEBUG */ +uint16_t packet_id_read_epoch (struct packet_id_net *pin,struct buffer *buf) {
@@ -711,6 +713,3 @@return buf_write (buf, &net_id,sizeof (net_id)); } - - -#endif /* ifdef ENABLE_DEBUG */
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1071?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3bed9c7aafee8e62ddae14c0d3e21cf4c146a37c
Gerrit-Change-Number: 1071
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged